Fix (part of) #6323: trust case class unapplies to produce checkable type tests #6551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type test comes from an unapply method of a case class, we trust it to generate a runtime-checkable type test, even if the test doesn't appear checkable. This fixes spurious warnings of the following kind:
The cause of the warning, as can be gleamed from the error message, is that we infer
Bar#X = A
.Bar[A]
is only guaranteed to be a subtype ofFoo[A, B]
under GADT constraintA = B
, but by the time we check type tests, that information is gone.Note that in the case where the unapply cannot possibly match, exhaustivity checker will still issue an error.