Test all pos & run tests with -Ytest-pickler #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBlanvillain
changed the title
|
Maybe it was only the separate compilation test that where no supported. |
| @@ -183,7 +183,9 @@ class CompilationTests extends ParallelTesting { | |||
| @Test def pickling: Unit = { | |||
| implicit val testGroup: TestGroup = TestGroup("testPickling") | |||
| compileFilesInDir("tests/new", picklingOptions) + | |||
| compileFilesInDir("tests/pickling", picklingOptions) | |||
| compileFilesInDir("tests/pickling", picklingOptions) + | |||
There was a problem hiding this comment.
Should we move all the pickling tests to pos?
OlivierBlanvillain
force-pushed
the
black-test-pickler-tests
branch
3 times, most recently
from
2d5fda5
to
81ef585
Compare
Move pickling/annot.scala to pending as it doesn't pass Ycheck, see scala#5073.
OlivierBlanvillain
force-pushed
the
black-test-pickler-tests
branch
from
81ef585
to
72a17e9
Compare
nicolasstucki
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR adds pickling tests for everything in
/posand/run, along with two blacklists to track what's currently failing.@nicolasstucki You told me that -Ytest-pickler can't deal with tests spread over multiple files, but it seems to handle them somehow, for instance tests/pickling/i1932