Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <:< and =:= to testy reflect Type #4887

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (even the comment is an aside). I'll leave the merge to you (lest you miss the comment ;-)).

def =:=(other: Type)(implicit ctx: Context): Boolean
def <:<(other: Type)(implicit ctx: Context): Boolean
}
implicit def TypeDeco(tpe: Type): TypeAPI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but we were thinking about making the implicit defs inline — did we forget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a larger refactor later. Now we don't have a standard way to inline both on bootstrap and non bootstraped

@nicolasstucki nicolasstucki merged commit f39943d into scala:master Aug 5, 2018
@allanrenucci allanrenucci deleted the add-tasty-reflect-subtype-check branch August 5, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants