Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix isomorphism tests of AndOrTypes under non-empty BinderPairs" to LTS #21986

Open
wants to merge 1 commit into
base: backport-lts-3.3-18503
Choose a base branch
from
Open

Backport "Fix isomorphism tests of AndOrTypes under non-empty BinderPairs" to LTS #21986

wants to merge 1 commit into from

Conversation

prolativ
Copy link
Contributor

Backports #21017 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@EugeneFlesselle @prolativ
Fix isomorphism tests of AndOrTypes under non-empty BinderPairs (#…
1aca443 
…21017)

Before the changes, when comparing two `HKTypeLambda` result types, the
list of binding pairs was lost when entering comparison of `AndOrType`s,
which caused the `equals` to fail, and hence prevented hash-consing.

Even though `M1` and `M2` in pos/i20858-min should still conform to
one-another, we entered a deep-subtype comparison because of the order
in which the TypeComparer does dealiasing of AppliedTypes, and
comparison of MatchCases and AndTypes.

Fix #20858
[Cherry-picked f2829c3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prolativ @EugeneFlesselle