Specialized traits design draft #21950
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
reviewed
Nov 15, 2024
| def hasNext: Boolean | ||
| def next(): Int | ||
|
|
||
| trait ArrayIterator_Int extends ArrayIterator[Int], Iterator[Int] |
There was a problem hiding this comment.
@odersky I've just tried it with 3.5.0 and it compiles fine with the following parents. But we agree that after erasure, we should have Iterator_Int anyways.
Suggested change
| trait ArrayIterator_Int extends ArrayIterator[Int], Iterator[Int] | |
| trait ArrayIterator_Int extends ArrayIterator[Int], Iterator_Int |
There was a problem hiding this comment.
I believe it does not work if you replace both uses, the one here and the one that would map Seq[Int] to Seq_Int.
bishabosha
reviewed
Nov 15, 2024
odersky
force-pushed
the
specialized-traits-design
branch
from
e550ab4
to
9daa075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.