Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Contains handling #21361

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Improve Contains handling #21361

merged 2 commits into from
Aug 12, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 10, 2024

Make use of enclosing Contains assumptions to improve the subsumes logic.

@odersky
Improve Contains handling
72a20bd 
Make use of enclosing Contains assumptions to improve the subsumes logic.
@odersky
Unrelated test: A Provider variant
b2292a8
@odersky odersky assigned odersky and natsukagami and unassigned odersky Aug 10, 2024
natsukagami
natsukagami approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also works for my case.

@odersky odersky merged commit b825f5a into scala:main Aug 12, 2024
28 checks passed
@odersky odersky deleted the improve-contains branch August 12, 2024 13:59
@odersky odersky mentioned this pull request Sep 12, 2024
Closed
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukagami natsukagami natsukagami approved these changes

Assignees

@natsukagami natsukagami

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @natsukagami @WojciechMazur