Backport "Export diagnostics (including unused warnings) to SemanticDB" #20315
+325
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
May 1, 2024
tests/semanticdb/metac.expect
Outdated
| @@ -1364,6 +1364,7 @@ Occurrences: | |||
|
|
|||
| Diagnostics: | |||
| [30:12..30:17): [warning] unused explicit parameter | |||
| [48:13..48:13): [warning] `:` after symbolic operator is deprecated; use backticks around operator instead | |||
bjaglin
commented
May 1, 2024
tests/semanticdb/metac.expect
Outdated
Comment on lines
3739
to
3741
| [30:11..30:18): [warning] unset local variable, consider using an immutable val instead | ||
| [30:20..30:28): [warning] unset local variable, consider using an immutable val instead | ||
| [31:15..31:25): [warning] unset local variable, consider using an immutable val instead |
bjaglin
commented
May 1, 2024
tests/semanticdb/metac.expect
Outdated
Comment on lines
1759
to
1761
| [24:53..24:63): [warning] An inline given alias with a function value as right-hand side can significantly increase | ||
| generated code size. You should either drop the `inline` or rewrite the given with an | ||
| explicit `apply` method. |
Merged
2 tasks
|
@WojciechMazur this PR does not seem to be present in the release notes of 3.3.4-RC1 (well done for all the work there!) even though it was merged. Is it maybe because it's a backport that you didn't do yourself? |
|
Sorry, I must have messed something up when categorizing the PRs. I can find this PR in |
|
Thanks @WojciechMazur. Don't worry for final, I will report back here if I see it missing, FWIW. I wonder though - can there be other PRs also missing from the changelog? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #17835 from @tanishiking to the LTS branch. Fixes (again) #17535, so that library authors stuck on LTS can benefit from it, at the very least through scalafix & metals.