Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax.md #19670

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Update syntax.md #19670

merged 5 commits into from
Feb 14, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 11, 2024

  1. Add missing soft modifiers
  2. Port changes from multiple type parameter sections to reference. Now that multiple type parameter sections are merged, this is the official syntax. This also covers extension method declarations.

Fixes #19667
Fixes #19668

 1. Add missing soft modifiers
 2. Port changes from multiple type parameter sections to reference.
    Now that multiple type parameter sections are merged, this is the
    official syntax. This also covers extension method declarations.

Fixes scala#19667
Fixes scala#19668
@odersky odersky marked this pull request as ready for review February 11, 2024 19:12
 - Change doc comments to match described syntax
 - Refactor `typ` method to make it clear it matches the syntax
erased is not always a modifier on the parameter name. The syntax `erased Type` is dropped.
There's not really a need for this syntactic inconsistency.
docs/_docs/reference/syntax.md Show resolved Hide resolved
docs/_docs/reference/syntax.md Outdated Show resolved Hide resolved
docs/_docs/reference/syntax.md Show resolved Hide resolved
docs/_docs/internals/syntax.md Outdated Show resolved Hide resolved
docs/_docs/internals/syntax.md Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/parsing/Parsers.scala Outdated Show resolved Hide resolved
docs/_docs/reference/syntax.md Show resolved Hide resolved
docs/_docs/internals/syntax.md Show resolved Hide resolved
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@odersky odersky merged commit b160bbb into scala:main Feb 14, 2024
19 checks passed
@odersky odersky deleted the update-syntax branch February 14, 2024 10:14
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
Backports #19670 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infix modifier is not covered by the EBNF Abstract extension methods are not covered by the EBNF
3 participants