Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightlies (revert #19113) #19289

Closed
wants to merge 3 commits into from

Conversation

nicolasstucki
Copy link
Contributor

Reverts #19113

Fixes #19285
Fixes #19281
Fixes #19278

Fixes https://github.com/lampepfl/dotty/actions/runs/7243042276

Error:  Test dotty.tools.dotc.CompilationTests.parallelBackend failed: java.util.concurrent.TimeoutException: Compiling targets timed out, remaining targets: out/parallelBackend/reference, took 1200.005 sec
Error:      at dotty.tools.vulpix.ParallelTesting$Test.executeTestSuite(ParallelTesting.scala:707)

@nicolasstucki

This comment was marked as outdated.

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caused by 10f2c10.

Can't be. #19113 was merged 15 hours ago and #19278 is from 2 days ago. Please don't revert my PR.

@nicolasstucki
Copy link
Contributor Author

This was caused by 10f2c10.

Can't be. #19113 was merged 15 hours ago and #19278 is from 2 days ago. Please don't revert my PR.

Maybe something did not do right with my git bisect. I will need to try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants