Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments on TASTy MiMa filters #19228

Merged

Conversation

nicolasstucki
Copy link
Contributor

[skip ci]

@nicolasstucki
Copy link
Contributor Author

@sjrd I don't remember what you said about

// Problem: ???
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.Predef.nn"), // The member scala.Predef.nn with signature (1,java.lang.Object):java.lang.Object does not have a correspondant in current version
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.Predef.ne"), // The member scala.Predef.ne with signature (java.lang.Object,java.lang.Object):scala.Boolean does not have a correspondant in current version
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.Predef.eq"), // The member scala.Predef.eq with signature (java.lang.Object,java.lang.Object):scala.Boolean does not have a correspondant in current version

@sjrd
Copy link
Member

sjrd commented Dec 8, 2023

nn, eq and ne are weird. Also other methods patched onto Predef from stdLibPatches.

When tasty-query reads Predef from a Scala 2 pickle, it artificially adds those methods. This imitates somewhat what dotc does, except that dotc generically copies from stdLibPatches whereas tasty-query hard-codes the patches.

When reading from TASTy, however, the code paths are different and tasty-query does not apply the patches.

So if the TASTy stdlib does not include those methods directly in the TASTy of Predef, TASTy-MiMa will complain.

Whether this should be fixed in tasty-query or in the TASTy of Predef is unclear. Ideally Since we want to eventually use the TASTy stdlib to enhance other parts of the library, it would be good to also do it directly for Predef.

@nicolasstucki
Copy link
Contributor Author

Whether this should be fixed in tasty-query or in the TASTy of Predef is unclear. Ideally Since we want to eventually use the TASTy stdlib to enhance other parts of the library, it would be good to also do it directly for Predef.

Following up in #19231. This adds the first step towards defining everything directly on Predef.

@nicolasstucki nicolasstucki force-pushed the update-comments-on-tasty-mima-filters branch from af74105 to c83ab27 Compare December 18, 2023 13:27
@sjrd sjrd merged commit 7d45958 into scala:main Dec 21, 2023
19 checks passed
@sjrd sjrd deleted the update-comments-on-tasty-mima-filters branch December 21, 2023 15:23
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants