Backport "use new zinc 1.8 api for VirtualFile" to LTS #19128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Cherry-picked a7cec5f][modified]
zinc 1.4 removes the dependency on protobuf-java, so fails to compile mtags-shared due to the now missing transitive dependency. The compiler implements protobuf streams for semanticdb, so reuse it in the source generator for mtags-shared. [Cherry-picked 34a5e45]
[Cherry-picked 2458b8f]
[Cherry-picked 95ed582]
[Cherry-picked 7dfb0cf]
[Cherry-picked 8f128fd]
[Cherry-picked 5fde72c]
[Cherry-picked aa27580]
[Cherry-picked 246dfc4][modified]
[Cherry-picked e3de91c]
|
how is the merge order decided, because it looks from a glance that at least this should depend on #19061 |
|
No regressions detected in the community build up to lts-16941. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #18137 to the LTS branch.
PR submitted by the release tooling.
[skip ci]