Remove linearization requirement for override ref checks from java classes #18953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneFlesselle
force-pushed
the
main
branch
from
61a6534 to
b61e010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking overriding/overriden pairs references, we can exclude those handled by the parent class, which requires them to be in linearization order. If the parent is java class however, this ordering should not be checked as linearization does not apply to them.
Closes #18654, closes #19007, and closes #18764
In particular, it fixes both:
But it does not fix https://scastie.scala-lang.org/3ioAIaRaQJ282KS69KugxA or any of its minimisations which have an external dependency.
@tpunder