Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify use of toFunctionType #18429

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Aug 21, 2023

Make isJava by default false and remove dropLast argument.

Part of #18305. Note that the use of toFunctionType will increase, and most will not be java functions.

Make `isJava` by default false.
@nicolasstucki nicolasstucki force-pushed the simplify-use-of-toFunctionType branch from bd937ea to eb8fba4 Compare August 21, 2023 07:49
If needed, use `derivedLambdaType` to drop the last parameters before
converting to a function type.
@nicolasstucki nicolasstucki force-pushed the simplify-use-of-toFunctionType branch from f9e12fe to 3419d8a Compare August 21, 2023 08:36
@nicolasstucki nicolasstucki marked this pull request as ready for review August 21, 2023 11:19
@nicolasstucki nicolasstucki requested a review from odersky August 21, 2023 14:06
@odersky odersky merged commit 8f621c6 into scala:main Aug 29, 2023
@odersky odersky deleted the simplify-use-of-toFunctionType branch August 29, 2023 16:13
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
Backports #18429 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
Backports #18429 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants