Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create legacy Scala 2/3 stdlib TASTy #18025

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 21, 2023

This adds a temporary workaround (stdlib-bootstrapped-legacy) to be able to generate documentation for the full standard library. In the future, the documentation will be generated from stdlib-bootstrapped and scala3-library-bootstrapped combined.

Fixes #17964
Fixes #17621

Partially reverts #17526

This adds a temporary workaround (`stdlib-bootsrapped-legacy`) to be
able to generate documentation for the full standard library. In the
future, the documentation will be generated from `stdlib-bootsrapped`
and `scala3-library-bootsrapped` combined.

Fixes scala#17964
@nicolasstucki
Copy link
Contributor Author

@Florian3k I was not sure which doc command to use to test sdtlib docs. Could you test and check that?

@Florian3k
Copy link
Contributor

Yes, everything seems to be working fine.

P.S. The commands are scaladoc/generateScalaDocumentation and scaladoc/generateStableScala3Documentation

@nicolasstucki nicolasstucki marked this pull request as ready for review June 21, 2023 14:29
@Florian3k Florian3k linked an issue Jun 26, 2023 that may be closed by this pull request
settings(
Compile / scalacOptions ++= {
Seq("-sourcepath", ((Compile/sourceManaged).value / "scala-library-src").toString)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was missing before, but you probably also want -sourcepath on Compile / scalaSource since you're putting files there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this in another PR

@smarter smarter assigned nicolasstucki and unassigned smarter Jun 28, 2023
@nicolasstucki nicolasstucki merged commit 1803802 into scala:main Jun 28, 2023
@nicolasstucki nicolasstucki deleted the create-legacy-scala2-scala3-library-tasty branch June 28, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly docs are missing Scala 3 parts of standard library dotty api docs, boundary is missing
3 participants