Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse beta reduction logic from BetaReduce #16390

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 22, 2022

Fixes a bug when beta-reducing inlined code. In some situations
the beta-reduction did not bind mutable variables.

@nicolasstucki nicolasstucki self-assigned this Nov 22, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from bfd295a to 7b769d2 Compare November 23, 2022 14:20
nicolasstucki added a commit to dotty-staging/spire that referenced this pull request Nov 25, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch 2 times, most recently from 2643ea2 to e0ac044 Compare November 25, 2022 16:37
@nicolasstucki nicolasstucki changed the title Reuse beta reduction logic from Beta-reduce Reuse beta reduction logic from BetaReduce Nov 25, 2022
@nicolasstucki nicolasstucki removed their assignment Nov 25, 2022
@nicolasstucki nicolasstucki marked this pull request as ready for review November 25, 2022 18:20
nicolasstucki added a commit to dotty-staging/spire that referenced this pull request Nov 28, 2022
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from e0ac044 to a83441c Compare November 28, 2022 08:13
Fixes a bug when beta-reducing inlined code. In some situations
the beta-reduction did not bind mutable variables.
@nicolasstucki nicolasstucki force-pushed the reuse-beta-reduction-logic-from-betaReduce branch from a83441c to 7558d27 Compare November 28, 2022 11:19
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@odersky odersky merged commit 8fba321 into scala:main Nov 28, 2022
@odersky odersky deleted the reuse-beta-reduction-logic-from-betaReduce branch November 28, 2022 16:00
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants