Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspects of the Show setup #15810

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Fix aspects of the Show setup #15810

merged 1 commit into from
Aug 28, 2022

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Aug 2, 2022

  1. Fix accidentally recursive ParamInfo instance, and test
  2. Add a missing Integer instance, needed for VarianceMap, and test
  3. Fix showing nested non-Showable, non-primitive values, for instance
    showing a value of type List[(Type, Int)] wasn't pretty-printing
    the Type. To fix this we need to introduce CtxShow, to defer the
    showing until we can wire a Context to it. And test. Additionally,
    we can do the non-sensical tagging with a Printer, like explainations
    does.
  4. Addtionally, that ^ change brings the em/ex features to nested values
    too, and add tests for those.
  5. Add some notes on how MessageLimiter works
  6. Fix OrderingContraint assuming ctx.run is non null.

@som-snytt
Copy link
Contributor

This should be labeled "Show-stopper".

@dwijnand dwijnand marked this pull request as ready for review August 2, 2022 23:35
@dwijnand dwijnand requested a review from odersky August 15, 2022 13:21
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes look good.

compiler/src/dotty/tools/dotc/printing/Formatting.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/printing/Formatting.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/printing/Formatting.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/printing/Formatting.scala Outdated Show resolved Hide resolved
@odersky odersky assigned dwijnand and unassigned odersky Aug 20, 2022
1. Fix accidentally recursive ParamInfo instance, and test
2. Add a missing Integer instance, needed for VarianceMap, and test
3. Fix showing nested non-Showable, non-primitive values, for instance
   showing a value of type `List[(Type, Int)]` wasn't pretty-printing
   the Type.  To fix this we need to introduce CtxShow, to defer the
   showing until we can wire a Context to it.  And test.  Additionally,
   we can do the non-sensical tagging with a Printer, like explainations
   does.
4. Addtionally, that ^ change brings the em/ex features to nested values
   too, and add tests for those.
5. Add some notes on how MessageLimiter works
6. Fix OrderingContraint assuming ctx.run is non null.
@dwijnand dwijnand merged commit 8a7c84c into scala:main Aug 28, 2022
@dwijnand dwijnand deleted the fix-Show-infra branch August 28, 2022 10:56
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants