Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly display value of value class in repl #15545

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Properly display value of value class in repl #15545

merged 5 commits into from
Jul 1, 2022

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Jun 28, 2022

Fixes #15493

@rochala rochala requested a review from smarter June 29, 2022 11:31
smarter
smarter requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

compiler/src/dotty/tools/repl/Rendering.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/repl/Rendering.scala Show resolved Hide resolved
@rochala rochala requested a review from smarter July 1, 2022 13:27
smarter
smarter approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for object Outer { class Foo(x: Int) extends AnyVal } too? Otherwise feel free to merge, LGTM!

@rochala rochala enabled auto-merge (squash) July 1, 2022 14:19
@rochala rochala merged commit 41678e6 into scala:main Jul 1, 2022
This was referenced Nov 22, 2022
Closed
Merged
smarter added a commit that referenced this pull request Dec 9, 2022
@smarter
REPL: Fix crash when printing instances of value classes (#16393)
231f9ab 
By fixing `Rendering`'s `rewrapValueClass` to use the fully qualified
class name

Sequel to #15545

Fixes #16322
Fixes #16387
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@rochala rochala

Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

REPL does not print toString of value classes
3 participants
@rochala @smarter @Kordyjan