Fix stability check for inline parameters #15511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
from
4e82831
to
9eecbd4
Compare
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
2 times, most recently
from
c8b2c1e
to
ab279ab
Compare
smarter
reviewed
Jul 4, 2022
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
4 times, most recently
from
b698278
to
5b131fa
Compare
nicolasstucki
added a commit
to dotty-staging/protoquill
that referenced
this pull request
Jul 8, 2022
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
from
5b131fa
to
2081372
Compare
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
from
2081372
to
21550f0
Compare
nicolasstucki
added a commit
to dotty-staging/protoquill
that referenced
this pull request
Dec 13, 2022
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
2 times, most recently
from
9b633f7
to
076b090
Compare
Inline parameters are not stable. Two references to the same parameter may not be idempotent.
nicolasstucki
force-pushed
the
fix-stability-check-for-inline-parameters
branch
from
076b090
to
77a8902
Compare
smarter
approved these changes
Dec 13, 2022
sjrd
added a commit
to sjrd/perspective
that referenced
this pull request
Aug 9, 2023
`inline` parameters can be evaluated several times, and therefore are not stable paths, so they cannot be used in path-dependent types. Checking this was fixed in Scala 3.3.0. See scala/scala3#15511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline parameters are not stable. Two references to the same parameter
may not be idempotent.