Java generic signatures can't refer to type members #15093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The PolyType case was dead code imported from Scala 2 - The HKTypeLambda case was correct for eta-expanded classes (e.g. in t7932 `Category[Tuple2]` should get as signature `Category<scala.Tuple2>`), but not for other type lambdas where it could lead to type members appearing in the signature. Fixed by splitting the case into an EtaExpansion case and a case for all other HKTypeLambdas (which are just replaced by a wildcard). Fixes scala#15091.
|
Ping for review. |
Kordyjan
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. in t7932
Category[Tuple2]should get as signatureCategory<scala.Tuple2>), but not for other type lambdaswhere it could lead to type members appearing in the signature.
Fixed by splitting the case into an EtaExpansion case and
a case for all other HKTypeLambdas (which are just replaced
by a wildcard).
Fixes #15091.