Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant type test for irrefutable @unchecked patterns #14898

Merged
merged 4 commits into from
Apr 16, 2022
Merged

Avoid redundant type test for irrefutable @unchecked patterns #14898

merged 4 commits into from
Apr 16, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 9, 2022 •
edited by griggt
Loading

Fixes #14896
Fixes #14821

@griggt
Copy link
Contributor

griggt commented Apr 9, 2022

@odersky Yes, this is more in line with what I thought the fix should be (as opposed to #14897).

I can confirm the Scala.js Tuple2 example now compiles with this change.

@odersky
Avoid double @unchecked annotation
f70b899 
Avoid double @unchecked annotation if selector is marked checkIrrefutable.
@odersky odersky requested a review from griggt April 9, 2022 18:08
griggt added 2 commits April 9, 2022 22:04
@griggt
Add regression test for Scala.js js.Tuple2 example
b8df544 
Since support for `isInstanceOf[Null]` is subject to change.
@griggt
Add regression test for scala#14821
05f5a6f
@griggt griggt merged commit 3156d50 into scala:main Apr 16, 2022
@griggt griggt deleted the fix-14896-v2 branch April 16, 2022 04:20
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griggt griggt griggt approved these changes

Assignees

@griggt griggt

Labels
None yet
Projects
None yet
Milestone
3.2.0
3 participants
@odersky @griggt @Kordyjan