Change @experimental spec #13305
Merged
Change @experimental spec #13305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
added
stat:wip
release-notes
nicolasstucki
force-pushed
the
experimental-annotation
branch
5 times, most recently
from
b73376c
to
c4edfde
Compare
nicolasstucki
force-pushed
the
experimental-annotation
branch
3 times, most recently
from
fb8bfc1
to
d08b595
Compare
nicolasstucki
force-pushed
the
experimental-annotation
branch
3 times, most recently
from
311c290
to
8f43d17
Compare
nicolasstucki
force-pushed
the
experimental-annotation
branch
from
8f43d17
to
1828dc1
Compare
smarter
approved these changes
Aug 20, 2021
| * As this definition is in `src-non-bootstrapped`, it will not be published. | ||
| * It may accidentally be visible while compiling the non-bootstrapped library. | ||
| */ | ||
| @experimental def testExperimental = 4 |
There was a problem hiding this comment.
Not sure how important it is to test this given that @experimental is no longer experimental itself now?
There was a problem hiding this comment.
This is not really there to check if @experimental is experimental, it is to check that we can define experimental definitions in the standard library. This is to make sure we catch a regression as early as possible as this kind of failure could block an update if the reference compiler.
Note that for 3.1.0 we will not have any other experimental definitions. They will all get stabilized.
Co-authored-by: Guillaume Martres <[email protected]>
odersky
approved these changes
Aug 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main differences with the current version is that @experimental is not experimental and that we are able to define experimental APIs using any version of the compiler (nightly, snapshot and stable release).
See
docs/docs/reference/experimental/experimental-defs.md.