Fix for issue #12551 #13006
Merged
Fix for issue #12551 #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jul 2, 2021
dist/bin/scala.bat
Outdated
| ) else if "%__ARG%"=="-with-compiler" ( | ||
| set _WITH_COMPILER=1 | ||
| ) else if "%__ARG%"=="-d" ( | ||
| set "_JAVA_DEBUG=%_DEBUG_STR%" |
There was a problem hiding this comment.
FYI, the -d is removed from the shell script, as well as _DEBUG_STR
|
|
||
| if not exist "%_SITE_DIR%" mkdir "%_SITE_DIR%" | ||
| call "%_PREFIX%\bin\scaladoc.bat" -d "%_SITE_DIR%" -project Hello "%_SOURCE%" | ||
| endlocal |
There was a problem hiding this comment.
We can add it to the CI like this one: https://github.com/lampepfl/dotty/blob/master/.github/workflows/ci.yaml#L159
anatoliykmetyuk
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix consists of two groups of batch files:
dist/bin/; they are based on the corresponding bash scripts and should be kept in sync with them.NB. The generated distribution archive (e.g.
scala3-3.0.2-RC1-bin-SNAPSHOT.zip) will include both the batch files and the bash scripts.winCmdTests; it is targeted at the Windows prompt while the bash script is targeted at Unix-like shells such as MingW, MSYS2 or WSL.NB. This batch file is to be executed by the CI job running on a GitHub managed Windows machine.