fix #12949: export synthetic given co-defined with class #12999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
added
the
needs-minor-release
Co-authored-by: Martin Odersky <[email protected]> Co-authored-by: Jamie Thompson <[email protected]>
bishabosha
force-pushed
the
fix-12949-alternative
branch
from
de6cbda
to
657ab61
Compare
|
Tentatively putting |
|
I think I prefer the solution to drop Synthetic. A given def is not synthetic; it's written by the user. If anything, it's the companion class that should be synthetic. And it's a good rule to say that synthetics are excluded from exports. So while #12979 is initially a more complicated change, it will make things more regular in the end, rather than adding one irregularity to compensate another one. |
|
I agree it is a bit strange to special case this one case of synthetic - closing this |
dwijnand
removed
the
needs-minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #12979 that does not introduce new flags