Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make def generated from givens not synthetic #12979

Merged
merged 10 commits into from
Aug 27, 2021

Commits on Aug 23, 2021

  1. Configuration menu
    Copy the full SHA
    941301f View commit details
    Browse the repository at this point in the history
  2. Another scheme to mark implicit methods that were synthetic

    Find other scheme to know whether some method is a structural given instance or
    an implicit conversion associated with an implicit class. Previously we characterized
    these methods by their Synthetic flag, but that meant that they were not automatically
    exported. So we now drop Synthetic and use a flag `GivenClass` on the class half of
    the pair.
    
    The old scheme is still recognized in order to maintain Tasty backwards compatibility.
    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    2fe623c View commit details
    Browse the repository at this point in the history
  3. Pickle GivenClass flag

    Pickle GivenClass flag as GIVEN
    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    78a010b View commit details
    Browse the repository at this point in the history
  4. Update repl expect file

    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5d7256d View commit details
    Browse the repository at this point in the history
  5. Specify GivenVal where appropriate

    Be more specific whether we specify a given or implicit val,
    or whether a class is also OK. This prepares the way for merging GivenClass
    and Given.
    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8a334ca View commit details
    Browse the repository at this point in the history
  6. Merge GivenClass and Given

    Classes can now be Given (if generated from a given def)
    or Implicit (if declared as an implicit class)
    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    064bb30 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0925ac5 View commit details
    Browse the repository at this point in the history
  8. Exclude implicit class conversions in SemanticDB

    Conversions generated for implicit classes were synthetic before,
    now they need to be excluded separately.
    odersky committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    9b5338d View commit details
    Browse the repository at this point in the history
  9. semanticdb - adjust occurences

    don't add definition occurences for given instance parameters
    bishabosha committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    ec3a21a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Configuration menu
    Copy the full SHA
    733200e View commit details
    Browse the repository at this point in the history