-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make def generated from givens not synthetic #12979
Merged
Merged
Commits on Aug 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 941301f - Browse repository at this point
Copy the full SHA 941301fView commit details -
Another scheme to mark implicit methods that were synthetic
Find other scheme to know whether some method is a structural given instance or an implicit conversion associated with an implicit class. Previously we characterized these methods by their Synthetic flag, but that meant that they were not automatically exported. So we now drop Synthetic and use a flag `GivenClass` on the class half of the pair. The old scheme is still recognized in order to maintain Tasty backwards compatibility.
Configuration menu - View commit details
-
Copy full SHA for 2fe623c - Browse repository at this point
Copy the full SHA 2fe623cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78a010b - Browse repository at this point
Copy the full SHA 78a010bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d7256d - Browse repository at this point
Copy the full SHA 5d7256dView commit details -
Specify GivenVal where appropriate
Be more specific whether we specify a given or implicit val, or whether a class is also OK. This prepares the way for merging GivenClass and Given.
Configuration menu - View commit details
-
Copy full SHA for 8a334ca - Browse repository at this point
Copy the full SHA 8a334caView commit details -
Classes can now be Given (if generated from a given def) or Implicit (if declared as an implicit class)
Configuration menu - View commit details
-
Copy full SHA for 064bb30 - Browse repository at this point
Copy the full SHA 064bb30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0925ac5 - Browse repository at this point
Copy the full SHA 0925ac5View commit details -
Exclude implicit class conversions in SemanticDB
Conversions generated for implicit classes were synthetic before, now they need to be excluded separately.
Configuration menu - View commit details
-
Copy full SHA for 9b5338d - Browse repository at this point
Copy the full SHA 9b5338dView commit details -
semanticdb - adjust occurences
don't add definition occurences for given instance parameters
Configuration menu - View commit details
-
Copy full SHA for ec3a21a - Browse repository at this point
Copy the full SHA ec3a21aView commit details
Commits on Aug 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 733200e - Browse repository at this point
Copy the full SHA 733200eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.