Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semanticdb test for #11693 #12599

Closed
wants to merge 1 commit into from

Conversation

tanishiking
Copy link
Member

#11693

I'm not sure which commit changed the semanticdb behavior, but it looks like already somehow fixed. Added regression tests by adding a code to toplevel.scala and run:

sbt
> scala3-compiler-bootstrapped/Test/runMain dotty.tools.dotc.semanticdb.updateExpect

scala#11693
> scala3-compiler-bootstrapped/Test/runMain dotty.tools.dotc.semanticdb.updateExpect
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this, unfortunately, the problem described in #11693 is still not fixed, as can be seen on the first line of the test file in this PR:
https://github.com/lampepfl/dotty/blob/78c9bc58d330cd2945c26d98fb9ddc215fe93a11/tests/semanticdb/expect/toplevel.expect.scala#L1

The problem is that there is any occurrence of the /*<-_empty_::toplevel$package.*/ definition, rather than only it appearing next to a given - this happens wherever the first top level definition in the file exists

@tanishiking
Copy link
Member Author

this happens wherever the first top level definition in the file exists

Ah, I see, thank you for the feedback!
I'll close this PR for now, since it may take some time to fix the underlying problem.

@tanishiking tanishiking deleted the add-tests-semanticdb branch May 26, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants