Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12405 - workaround for fragile jline3 console detection in REPL #12411

Merged
merged 2 commits into from
May 11, 2021
Merged

Fix #12405 - workaround for fragile jline3 console detection in REPL #12411

merged 2 commits into from
May 11, 2021

Conversation

philwalk
Copy link
Contributor

@philwalk philwalk commented May 10, 2021

This fixes 2 issues:

  1. add workaround for console detection issues (see jline3 console detection is fragile in Windows cmd.exe, cygwin, msys, and mingw environments. #12405)
  2. refine the handling of JNA classpath variable for various combinations of ConEmu and shell

In Windows Console, these REPL combinations are made fully functional:

MINGW64_NT-10.0-19042 d5 3.1.7-340.x86_64 2020-11-08 12:32 UTC x86_64 Msys
MINGW32_NT-10.0-19042 d5 3.1.7-340.x86_64 2020-11-08 12:32 UTC x86_64 Msys
MSYS_NT-10.0-19042 d5 3.1.7-340.x86_64 2020-11-08 12:32 UTC x86_64 Msys
CYGWIN_NT-10.0 d5 3.2.0(0.340/5/3) 2021-03-29 08:42 x86_64 Cygwin

In ConEmu, these are fully functional:

MINGW64_NT-10.0-19042 d5 3.1.7-340.x86_64 2020-10-23 13:08 UTC x86_64 Msys
CYGWIN_NT-10.0 d5 3.2.0(0.340/5/3) 2021-03-29 08:42 x86_64 Cygwin

In mintty, cygwin64 is fully functional

CYGWIN_NT-10.0 d5 3.2.0(0.340/5/3) 2021-03-29 08:42 x86_64 Cygwin

Some other combinations are partially functional (arrow keys don't work, might need to set TERM=dumb).

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @philwalk 🎉

@liufengyun liufengyun merged commit 0ba5b55 into scala:master May 11, 2021
@philwalk philwalk deleted the fix-12405 branch May 11, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants