Fix type test for trait parameter arguments #12041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
Apr 12, 2021
| val params = parentCls.asClass.paramGetters | ||
| val args = termArgss(app).flatten | ||
| for (param, arg) <- params.lazyZip(args) do | ||
| if !param.is(Private) then // its type can be narrowed through intersection -> a check is needed |
There was a problem hiding this comment.
It is a good idea to check this one here, I didn't do that in #11059.
b-studios
reviewed
Apr 12, 2021
| then | ||
| report.error(IllegalParameterInit(arg.tpe, paramType, param, cls), arg.srcPos) | ||
|
|
||
| for case app: Apply <- parentTrees do checkParamInits(app) |
There was a problem hiding this comment.
yes, it's also a better idea to walk through the constructors.
This was referenced Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11993