Only pickle StableRealizable flag for methods #11858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala#9276 That aligns behavior with the TastyFormat doc, where it says: STABLE -- Method that is assumed to be stable, i.e. its applications are legal paths For other occurrences of StableRealizable, we either reconstitute them if they are implied (i.e. for module vals and enum values), or we recompute them in realizability checking as needed.
|
what is an example of a method that would get the it seems constructors and exported forwarders get them at desugaring at least |
|
@bishabosha The methods that get it now are export forwarders and constructors and parameter forwarders (but I think these get created only after pickling). But there might be others in the future. Also, we might want to add the possibility that a user can annotate a method with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9276
That aligns behavior with the TastyFormat doc, where it says:
For other occurrences of StableRealizable, we either reconstitute them if they are implied
(i.e. for module vals and enum values), or we recompute them in realizability checking as needed.