Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't point to the compiler backlog when a compiler plugin phase crashes #21783

Closed
Gedochao opened this issue Oct 16, 2024 · 0 comments · Fixed by #21887
Closed

Don't point to the compiler backlog when a compiler plugin phase crashes #21783

Gedochao opened this issue Oct 16, 2024 · 0 comments · Fixed by #21887
Assignees
Labels
area:compiler-plugins Issues tied with handling of compiler plugins. area:reporting Error reporting including formatting, implicit suggestions, etc better-errors Issues concerned with improving confusing/unhelpful diagnostic messages itype:enhancement

Comments

@Gedochao
Copy link
Contributor

Compiler version

3.6.1-RC1-bin-20241014-69ac5fb-NIGHTLY

Description

Currently, when a compiler plugin phase crashes, we still point the user to the Scala compiler backlog.
For example, a crash with stainless produces output like this:

An unhandled exception was thrown in the compiler.
  Please file a crash report here:
  https://github.com/scala/scala3/issues/new/choose
  For non-enriched exceptions, compile with -Xno-enrich-error-messages.

     while compiling: BugReport.scala
        during phase: stainless
                mode: Mode(ImplicitsEnabled)
     library version: version 2.13.14
    compiler version: version 3.5.0
            settings: -Wsafe-init true -classpath 

We should indicate to the user that they should raise the crash to the compiler plugin maintainers, rather than us.

Context

This is a follow-up issue to:

Expectation

I'd expect output similar to:

An unhandled exception was thrown in the compiler.
  Please file a crash report in the compiler plugin backlog.
  The name of the compiler plugin which caused the crash is "stainless".
  For non-enriched exceptions, compile with -Xno-enrich-error-messages.

     while compiling: BugReport.scala
        during phase: stainless
                mode: Mode(ImplicitsEnabled)
     library version: version 2.13.14
    compiler version: version 3.5.0
            settings: -Wsafe-init true -classpath 
@Gedochao Gedochao added itype:bug area:reporting Error reporting including formatting, implicit suggestions, etc better-errors Issues concerned with improving confusing/unhelpful diagnostic messages area:compiler-plugins Issues tied with handling of compiler plugins. itype:enhancement and removed itype:bug labels Oct 16, 2024
KacperFKorban added a commit to dotty-staging/dotty that referenced this issue Nov 20, 2024
KacperFKorban added a commit to dotty-staging/dotty that referenced this issue Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:compiler-plugins Issues tied with handling of compiler plugins. area:reporting Error reporting including formatting, implicit suggestions, etc better-errors Issues concerned with improving confusing/unhelpful diagnostic messages itype:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants