Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Dotty workflow of 2024-01-18 failed #19467

Closed
github-actions bot opened this issue Jan 18, 2024 · 2 comments · Fixed by #19468
Closed

Nightly Dotty workflow of 2024-01-18 failed #19467

github-actions bot opened this issue Jan 18, 2024 · 2 comments · Fixed by #19468
Assignees
@nicolasstucki
Labels
itype:bug prio:blocker
Milestone
3.4.1

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/7564727197
@nicolasstucki
Copy link
Contributor 

info] Test dotty.tools.pc.tests.hover.HoverTermSuite.import-rename2 started
Error:  Test dotty.tools.pc.tests.hover.HoverTermSuite.import-rename2 failed: java.lang.AssertionError: 
Error:   (+++ Expected, --- Obtained, NO CHANGES)
Error:  
Error:    ```scala
Error:  - type AB = AbstractMap
Error:    type S = Set
Error:  + type AB = AbstractMap
Error:    ```
Error:    
Error:    ```scala
Error:    def test(d: S[Int], f: S[Char]): AB[Int, String]
Error:    ```
Error:  
Error:  , took 0.069 sec

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jan 18, 2024 •
edited
Loading

There seems to be some non-deterministic ordering of the definitions. Probably a Map or Set is used.

It seems I can reproduce it most of the time by executing

sbt> testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *import-rename2

But not

sbt> testOnly dotty.tools.pc.tests.hover.HoverTermSuite

@nicolasstucki nicolasstucki self-assigned this Jan 18, 2024
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jan 18, 2024
@nicolasstucki
Make order of renames and missing imports deterministic
92a3f26 
Fixes scala#19467
@nicolasstucki nicolasstucki mentioned this issue Jan 18, 2024
Merged
bishabosha added a commit that referenced this issue Jan 19, 2024
@bishabosha
Make order of renames and missing imports deterministic (#19468)
36ee954 
Fixes #19467
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
WojciechMazur pushed a commit that referenced this issue Jun 27, 2024
@nicolasstucki @WojciechMazur
Make order of renames and missing imports deterministic
b7b89a2 
Fixes #19467

[Cherry-picked 92a3f26]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
itype:bug prio:blocker
Projects
None yet
Milestone
3.4.1
Development

Successfully merging a pull request may close this issue.

Make order of renames and missing imports deterministic dotty-staging/dotty
2 participants
@nicolasstucki @Kordyjan