Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up scala.runtime #10602

Closed
4 of 5 tasks
anatoliykmetyuk opened this issue Dec 2, 2020 · 3 comments
Closed
4 of 5 tasks

Clean-up scala.runtime #10602

anatoliykmetyuk opened this issue Dec 2, 2020 · 3 comments
Assignees
Milestone

Comments

@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Dec 2, 2020

As per the stdlib review discussion we had a few weeks ago, here's what needs to be done with scala.runtime package:

  • Rename Tuple.scala -> Tuples.scala
  • Move everything from dotty.runtime to.runtime – everything move
  • LazyVals: don't rely on Unsafe in Java 9 – copypaste Scala 2 stdlib code & detect usages
  • Remove TupledFunction
  • Function$ classes – investigate
@bishabosha
Copy link
Member

should scala.quoted.runtime become scala.runtime.quoted?

@smarter
Copy link
Member

smarter commented Dec 2, 2020

I think either is fine.

@nicolasstucki nicolasstucki removed their assignment Dec 3, 2020
@anatoliykmetyuk anatoliykmetyuk modified the milestones: 3.0.0-M3, 3.0.0-RC1 Dec 14, 2020
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 5, 2021
To avoid confusion with scala.Tuple. Part of scala#10602.
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 5, 2021
To avoid confusion with scala.Tuple. Part of scala#10602.
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 5, 2021
To avoid confusion with scala.Tuple. Part of scala#10602.
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 5, 2021
To avoid confusion with scala.Tuple. Part of scala#10602.
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 5, 2021
To avoid confusion with scala.Tuple. Part of scala#10602.
@smarter
Copy link
Member

smarter commented Jan 6, 2021

The only remaining item is the usage of sun.misc.Unsafe in LazyVals, but I had a look and trying to abtract over this to use VarHandle on Java 9+ instead looks very complicated and will involve some important changes to the lazy val implementation, this is likely to be a wasted effort since we're anyway going to completely change it post-3.0 with #7140, so I'll be closing this and we'll have to handle this at the same time we deal with #7140.

@smarter smarter closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants