Skip to content

Commit

Permalink
Consider all parents when checking access to the children of a sum
Browse files Browse the repository at this point in the history
  • Loading branch information
EugeneFlesselle committed Nov 26, 2023
1 parent 55c2002 commit 7be702b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
5 changes: 2 additions & 3 deletions compiler/src/dotty/tools/dotc/core/SymUtils.scala
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class SymUtils:
else {
val children = self.children
val companionMirror = self.useCompanionAsSumMirror
val ownerScope = if pre.isInstanceOf[SingletonType] then pre.classSymbol else NoSymbol
val ownerScope = if pre.isInstanceOf[SingletonType] then pre.parentSymbols(_.isClass) else Nil
def problem(child: Symbol) = {

def accessibleMessage(sym: Symbol): String =
Expand All @@ -191,8 +191,7 @@ class SymUtils:
self.isContainedIn(sym) || sym.is(Module) && isVisibleToParent(sym.owner)
def isVisibleToScope(sym: Symbol): Boolean =
def isReachable: Boolean = ctx.owner.isContainedIn(sym)
def isMemberOfPrefix: Boolean =
ownerScope.exists && inherits(sym, ownerScope)
def isMemberOfPrefix: Boolean = ownerScope.exists(inherits(sym, _))
isReachable || isMemberOfPrefix || sym.is(Module) && isVisibleToScope(sym.owner)
if !isVisibleToParent(sym) then i"to its parent $self"
else if !companionMirror && !isVisibleToScope(sym) then i"to call site ${ctx.owner}"
Expand Down
17 changes: 17 additions & 0 deletions tests/pos/i18918.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

trait SuperTrait {
sealed trait InnerTrait
case class Foo() extends InnerTrait
}

trait OtherTrait

trait TraitWithSelfType extends SuperTrait { this: OtherTrait =>
summon[deriving.Mirror.Of[Foo]]
summon[deriving.Mirror.Of[InnerTrait]]
}

object Implementation extends TraitWithSelfType, OtherTrait {
summon[deriving.Mirror.Of[Foo]]
summon[deriving.Mirror.Of[InnerTrait]]
}

0 comments on commit 7be702b

Please sign in to comment.