Fix REPL shadowing bug

scala · Nov 22, 2022 · 6e86fbe · 6e86fbe
1 parent 298ff3f
commit 6e86fbe
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 2 deletions.
diff --git a/compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala b/compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala
@@ -1060,7 +1060,7 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {
     if (sym.isImport)
       sym.infoOrCompleter match {
         case info: Namer#Completer => return info.original.show
-        case info: ImportType => return s"import $info.expr.show"
+        case info: ImportType => return s"import ${info.expr.show}"
         case _ =>
       }
     def name =

diff --git a/compiler/src/dotty/tools/repl/ReplCompiler.scala b/compiler/src/dotty/tools/repl/ReplCompiler.scala
@@ -62,8 +62,8 @@ class ReplCompiler extends Compiler:
         }
 
         val rootCtx = super.rootContext.fresh
-          .setOwner(defn.EmptyPackageClass)
           .withRootImports
+          .fresh.setOwner(defn.EmptyPackageClass): Context
         (state.validObjectIndexes).foldLeft(rootCtx)((ctx, id) =>
           importPreviousRun(id)(using ctx))
       }

diff --git a/compiler/test/dotty/tools/repl/ShadowingBatchTests.scala b/compiler/test/dotty/tools/repl/ShadowingBatchTests.scala
@@ -32,6 +32,20 @@ class ShadowingBatchTests extends ErrorMessagesTest:
     ictx.setSetting(classpath, classpath.value + File.pathSeparator + dir.jpath.toAbsolutePath)
   }
 
+  @Test def io =
+    val lib = """|package io.foo
+                 |
+                 |object Bar {
+                 |  def baz: Int = 42
+                 |}
+                 |""".stripMargin
+    val app = """|object Main:
+                 |  def main(args: Array[String]): Unit =
+                 |    println(io.foo.Bar.baz)
+                 |""".stripMargin
+    checkMessages(lib).expectNoErrors
+    checkMessages(app).expectNoErrors
+
   @Test def file =
     checkMessages("class C(val c: Int)").expectNoErrors
     checkMessages("object rsline1 {\n  def line1 = new C().c\n}").expect { (_, msgs) =>

diff --git a/compiler/test/dotty/tools/repl/ShadowingTests.scala b/compiler/test/dotty/tools/repl/ShadowingTests.scala
@@ -76,6 +76,18 @@ class ShadowingTests extends ReplTest(options = ShadowingTests.options):
     Files.delete(file)
   end compileShadowed
 
+  @Test def io = shadowedScriptedTest(name = "io",
+    shadowed = """|package io.foo
+                  |
+                  |object Bar {
+                  |  def baz: Int = 42
+                  |}
+                  |""".stripMargin,
+    script = """|scala> io.foo.Bar.baz
+                |val res0: Int = 42
+                |""".stripMargin
+  )
+
   @Test def i7635 = shadowedScriptedTest(name = "<i7635>",
     shadowed = "class C(val c: Int)",
     script =
@@ -129,6 +141,11 @@ class ShadowingTests extends ReplTest(options = ShadowingTests.options):
     ShadowingTests.createSubDir("util")
     testScript(name = "<shadow-subdir-util>",
       """|scala> import util.Try
+         |-- [E008] Not Found Error: -----------------------------------------------------
+         |1 | import util.Try
+         |  |             ^^^
+         |  |             value Try is not a member of util
+         |1 error found
          |
          |scala> object util { class Try { override def toString = "you've gotta try!" }  }
          |// defined object util