Generalize condition when to skip override checking for Java members #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jun 1, 2021
dwijnand
approved these changes
Jun 1, 2021
|
@SethTisue do you prefer to run the community build on this before merging, or after? It's possible that something will pop up. |
|
let's do the community build before merging. (but not today, the behemoths are busy) (reason being that the longer these chains of adjustments and reversions become, the harder it is for archaeologists to follow the plot) |
|
Community build run is green. (The one failure is intermittent and unrelated.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12407
Follow-up for #9629