Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail to HashMap's lookup error message #9621

Merged
merged 2 commits into from
May 10, 2021
Merged

Add detail to HashMap's lookup error message #9621

merged 2 commits into from
May 10, 2021

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented May 9, 2021

Fixes scala/bug#12391

Scala 2.13 throws NoSuchElementException without any messages.
It's expected to throw "key not found: x"
This fixes it.

@eed3si9n
Fixes HashMap error message
27afdd3 
Fixes scala bug 12391

Scala 2.13 throws NoSuchElementException without any messages.
It's expected to throw "key not found: x"
This fixes it.
@scala-jenkins scala-jenkins added this to the 2.13.6 milestone May 9, 2021
@eed3si9n eed3si9n mentioned this pull request May 9, 2021
Closed
som-snytt
som-snytt approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested different characters because too much time on my hands. Oh just realized I forgot about the suggest feature in github.

@dwijnand dwijnand changed the title Fixes HashMap error message Add detail to HashMap's lookup error message May 10, 2021
dwijnand
dwijnand approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Eugene.

@dwijnand dwijnand merged commit 82af885 into scala:2.13.x May 10, 2021
@eed3si9n eed3si9n deleted the wip/hashmap branch May 10, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt approved these changes

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.6
4 participants
@eed3si9n @dwijnand @som-snytt @scala-jenkins