Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVERTED] Partest uses -release 8 #10056

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

som-snytt
Copy link
Contributor

If a partest does not specify javaVersion: or scalac: -release N, then always use -release 8.

This avoids the hassle of accidentally committing a test that uses recent API.

A future enhancement would be to infer javaVersion from -release.

cherry-picked from #9893

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Jun 15, 2022
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jun 16, 2022
@som-snytt som-snytt marked this pull request as ready for review June 16, 2022 13:50
@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.9 Jun 16, 2022
@som-snytt som-snytt merged commit 69bf66c into scala:2.13.x Jun 17, 2022
@som-snytt som-snytt deleted the topic/partest-release-8 branch June 17, 2022 22:07
@SethTisue SethTisue changed the title Partest uses -release 8 [REVERTED] Partest uses -release 8 Jun 24, 2022
@SethTisue SethTisue removed this from the 2.13.9 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants