Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate XInclude work - and fail #658

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Demonstrate XInclude work - and fail #658

merged 1 commit into from
Apr 24, 2023

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Apr 2, 2023

This pull request does not affect production code at all; it:

  • adds a test dependency on Xerces;
  • adjust tests that assume that JDK-built-in Xerces is the only Xerces on the classpath;
  • adds tests demonstrating that XInclude works;
  • adds tests demonstrating when XInclude fails miserably because of the old and never fixed Xerces bug...

@dubinsky dubinsky marked this pull request as ready for review April 2, 2023 22:09
@dubinsky dubinsky requested a review from SethTisue April 19, 2023 14:14
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any expertise on the specifics here, but I think you should go ahead and merge it.

@dubinsky
Copy link
Contributor Author

I don't have any expertise on the specifics here, but I think you should go ahead and merge it.

Thank you!
Maybe you have some ideas on how we can encourage the Xerces team to fix a 20-years old bug? ;)

@dubinsky dubinsky merged commit 42a59a8 into scala:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants