Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore XML CDATA sections when parsing: #558

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Do not ignore XML CDATA sections when parsing: #558

merged 1 commit into from
Sep 9, 2021

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Sep 1, 2021 •
edited
Loading

  • handle startCDATA/endCDATA lexical events;
  • keep track of the inCDATA state;
  • capture text into appropriate Node subtype depending on that state;
  • add createPCData()/makePCData() helpers;
  • add unit tests.

@dubinsky
Do not ignore XML CDATA sections when parsing:
5e8aba5 
- handle startCDATA/endCDATA lexical events;
- keep track of the `inCDATA` state;
- capture text into appropriate Node subtype depending on that state;
- add createPCData()/makePCData() helpers;
- add unit tests.
@dubinsky dubinsky marked this pull request as ready for review September 1, 2021 19:31
@dubinsky
Copy link
Contributor Author

dubinsky commented Sep 1, 2021

@ashawley @SethTisue a bit more of the lexical stuff

@ashawley
Copy link
Member

ashawley commented Sep 9, 2021

LGTM! Thanks for contributing this.

@SethTisue SethTisue merged commit b7053b6 into scala:main Sep 9, 2021
@SethTisue
Copy link
Member

Thank you!

@SethTisue SethTisue mentioned this pull request Sep 9, 2021
Open
@dubinsky
Copy link
Contributor Author

LGTM! Thanks for contributing this.

It's my pleasure!

@SethTisue SethTisue mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashawley ashawley ashawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubinsky @ashawley @SethTisue