Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2.13.0 (and the new collections) #148

Closed
wants to merge 2 commits into from

Conversation

julienrf
Copy link
Contributor

No description provided.

Use distinct implementations of PagedSeq according to the scala version.
Use JavaConverters rather than JavaConversions.
Use ++= instead of copyToBuffer.
@julienrf
Copy link
Contributor Author

Only the scala-parser-combinatorsJVM module compiles. We still lack a 2.13 compatible Scala.js release.

@SethTisue
Copy link
Member

Scala.js 0.6.23 is now published for 2.13.0-M4

@gourlaysama
Copy link
Contributor

Moved to #152.


private[input] trait ScalaVersionSpecificPagedSeq[T] { self: PagedSeq[T] =>
// Members declared in scala.collection.Seq
override def iterableFactory: collection.SeqFactory[collection.IndexedSeq] = collection.IndexedSeq

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrf why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is not anymore required, actually. Because we override it with the same body as the inherited one…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants