Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVE-2022-36944 for LazyList #569

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Fix CVE-2022-36944 for LazyList #569

merged 1 commit into from
Nov 25, 2022

Conversation

NthPortal
Copy link
Contributor

Backport fix for CVE-2022-36944 from 2.13.

Code copy-pasted in a browser.

Fixes #557

@NthPortal NthPortal added bug Something isn't working backport Backport of changes from 2.13 to methods/classes already present labels Nov 10, 2022
@NthPortal NthPortal requested a review from lrytz November 10, 2022 14:17
@NthPortal
Copy link
Contributor Author

files need formatting, and there's a ReflectUtil thing that needs addressing. otherwise, this is copied directly from 2.13. there's not a lot more I can do from a browser. hopefully it's not too much work for someone to address that one thing and run scalafmt (and probably squash the commits)

@SethTisue SethTisue mentioned this pull request Nov 23, 2022
Closed
@lrytz lrytz force-pushed the marissa/cve-2022-36944 branch from aea4fd6 to 185066a Compare November 25, 2022 09:53
@NthPortal @lrytz
Fix CVE-2022-36944 for LazyList
366d7a1 
Backport fix for CVE-2022-36944 from 2.13.

Code copy-pasted in a browser.
@lrytz lrytz force-pushed the marissa/cve-2022-36944 branch from 185066a to 366d7a1 Compare November 25, 2022 10:06
lrytz
lrytz approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NthPortal

@lrytz lrytz merged commit 7030af3 into main Nov 25, 2022
@xuwei-k xuwei-k deleted the marissa/cve-2022-36944 branch November 25, 2022 10:14
@functicons
Copy link

@NthPortal is it possible to backport this patch to 2.7 and release a new 2.7.x? (Upgrading to 2.9 is not feasible for our project for backwards compatibility).

@functicons functicons mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
backport Backport of changes from 2.13 to methods/classes already present bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For security, prevent Function0 execution during LazyList deserialization (backport from 2.13)
3 participants
@NthPortal @functicons @lrytz