-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add javaapi collection forwarders for 2.12 and 2.11 #551
Conversation
review by @scala/collections ? |
Well, this certainly looks plausible to me. Anyone else want to take a look? Otherwise I guess we'll optimistically merge. |
@DieBauer |
9442429
to
5c76f7b
Compare
Thanks for the hints! headers added, and sources formatted according to scalafmt, and squashed in a single commit |
The 2.11 and 2.12 build fails the
|
You need to change the |
I see the policy was changed with this PR: #553 |
in this PR is fine, but in its own commit is best |
Adds 2.13 collection compatible forwarders for scala 2.11 and scala 2.12, see scala#346. 2.11 has converters in traits WrapAsJava and WrapAsScala, while 2.12 has them in AsJavaConverters and AsScalaConverters. The method names are the same, but unfortunately both CollectionConverters objects have to be separately defined for both sources, because of this import. Tests are added in a Java file, to verify that the methods can be called as java api.
5c76f7b
to
39b57cf
Compare
Thank you! |
This PR adds 2.13 collection compatible forwarders for scala 2.11 and scala 2.12, see #346.
2.11 has converters in traits WrapAsJava and WrapAsScala, while 2.12 has them in AsJavaConverters and AsScalaConverters.
The method names are the same, but unfortunately both CollectionConverters objects have to be separately defined for both sources, because of this import.
Tests are added in a Java file, to verify that the methods can be called as java api.