Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset MiMa on 2.5.0 #469

Merged
merged 1 commit into from
Jul 9, 2021
Merged

reset MiMa on 2.5.0 #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Only the most commonly used APIs are supported; many are missing. Contributions
To use this library, add the following to your `build.sbt`:

```
libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "2.4.4"
libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "2.5.0"
```

All future versions will remain backwards binary compatible with 2.0.0. (The 1.0.0 release was withdrawn and should not be used.)
Expand Down Expand Up @@ -64,7 +64,7 @@ The `Collection213Upgrade` rewrite upgrades to the 2.13 collections without the

```scala
// build.sbt
ThisBuild / scalafixDependencies += "org.scala-lang.modules" %% "scala-collection-migrations" % "2.4.4"
ThisBuild / scalafixDependencies += "org.scala-lang.modules" %% "scala-collection-migrations" % "2.5.0"
addCompilerPlugin(scalafixSemanticdb)
scalacOptions ++= List("-Yrangepos", "-P:semanticdb:synthetics:on")
```
Expand All @@ -82,8 +82,8 @@ To cross-build for 2.12 and 2.11, the rewrite rule introduces a dependency on th

```scala
// build.sbt
ThisBuild / scalafixDependencies += "org.scala-lang.modules" %% "scala-collection-migrations" % "2.4.4"
libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "2.4.4"
ThisBuild / scalafixDependencies += "org.scala-lang.modules" %% "scala-collection-migrations" % "2.5.0"
libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "2.5.0"
addCompilerPlugin(scalafixSemanticdb)
scalacOptions ++= List("-Yrangepos", "-P:semanticdb:synthetics:on")
```
Expand Down
7 changes: 1 addition & 6 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,12 @@ lazy val compat = MultiScalaCrossProject(JSPlatform, JVMPlatform, NativePlatform
.jvmSettings(
Test / unmanagedSourceDirectories += (ThisBuild / baseDirectory).value / "compat/src/test/scala-jvm",
junit,
scalaModuleMimaPreviousVersion := (CrossVersion.partialVersion(scalaVersion.value) match {
case Some((3, _)) => None
case _ => Some("2.4.0")
}),
scalaModuleMimaPreviousVersion := Some("2.5.0"),
mimaBinaryIssueFilters ++= {
import com.typesafe.tools.mima.core._
import com.typesafe.tools.mima.core.ProblemFilters._
Seq(
exclude[ReversedMissingMethodProblem]("scala.collection.compat.PackageShared.*"), // it's package-private
exclude[MissingClassProblem]("scala.annotation.nowarn"), // it's part of scala-library from 2.12.13 onwards
exclude[MissingClassProblem]("scala.annotation.nowarn$") // it's part of scala-library from 2.12.13 onwards
)
},
)
Expand Down