Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Introduce Cloneable trait #369

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Introduce Cloneable trait #369

merged 1 commit into from
Jan 29, 2018

Conversation

julienrf
Copy link
Contributor

Fixes #365

@julienrf julienrf requested a review from lrytz January 25, 2018 14:30
@lrytz
Copy link
Member

lrytz commented Jan 25, 2018

There's also mutable.Queue, which currently extends plain Cloneable - this should probably just be removed, as Queue inherits from mutable.SeqOps.

hrhino
hrhino reviewed Jan 25, 2018
View reviewed changes
collections/src/main/scala/strawman/collection/mutable/Cloneable.scala Outdated
*
* @since 2.8
*
* @tparam A Type of the elements contained in the collection, covariant and with reference types as upperbound.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be Type of the collection, ...?

@julienrf
Copy link
Contributor Author

Good catch @hrhino, I copy-pasted the existing scaladoc without even checking that it was correct…

@lrytz mutable.Queue is not currently in master but, yes, we will have to remember to simplify its inheritance chain when we put it to master.

@lrytz
Copy link
Member

lrytz commented Jan 29, 2018

@julienrf I must have confused my intellij windows again :-)

@julienrf julienrf merged commit d18bdab into scala:master Jan 29, 2018
@julienrf julienrf deleted the cloneable branch January 29, 2018 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hrhino hrhino hrhino left review comments

@lrytz lrytz Awaiting requested review from lrytz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrf @lrytz @hrhino