This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Bring back WrappedString #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
suggested changes
Jan 19, 2018
| * @define Coll `WrappedString` | ||
| * @define coll wrapped string | ||
| */ | ||
| final class WrappedString(val self: String) extends AbstractSeq[Char] with IndexedSeq[Char] { |
There was a problem hiding this comment.
Maybe it’s time to have AbstractIndexedSeq?
There was a problem hiding this comment.
This is the same as in the old collections. There's collection.AbstractSeq but no collection.AbstractIndexedSeq or immutable.Abstract*. I'll do some more experiments and possibly open another PR. First tests show that immutable.AbstractSeq could be worth it, but immutable.AbstractIndexedSeq is probably not.
| val s = it.knownSize | ||
| if(s >= 0) b.sizeHint(s) | ||
| case _ => | ||
| } |
There was a problem hiding this comment.
Note that IterableOnce has knownSize so you don’t have to type test for Iterable
The motivation is the same as for Arrays which were originally wrapped in ArrayView but we later changed it back to WrappedArray (and ImmutableArray): It is very convenient to have an implicit conversion of a String to a Seq[Char] but a View is no longer a Seq in the new collection library.
szeiger
force-pushed
the
wip/wrappedstring
branch
from
b871ac2 to
1694421
Compare
julienrf
approved these changes
Jan 19, 2018
julienrf
reviewed
Jan 19, 2018
| protected[this] def fromSpecificIterable(coll: strawman.collection.Iterable[Char]): IndexedSeq[Char] = | ||
| WrappedString.fromSpecific(coll) | ||
| protected[this] def newSpecificBuilder(): Builder[Char, IndexedSeq[Char]] = WrappedString.newBuilder() | ||
| def iterableFactory: SeqFactory[IndexedSeq] = ImmutableArray |
There was a problem hiding this comment.
Why not use the default IndexedSeq implementation?
There was a problem hiding this comment.
Being a fixed-size array it's the most similar to String in spirit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is the same as for Arrays which were originally
wrapped in ArrayView but we later changed it back to WrappedArray
(and ImmutableArray): It is very convenient to have an implicit
conversion of a String to a Seq[Char] but a View is no longer a Seq
in the new collection library.