This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Rename Growable.add to addOne #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
approved these changes
Jan 11, 2018
- Align Shrinkable with Growable: subtract becomes subtractOne, the multi-element overload of subtract is removed in favor of -= - Rename Set.insert to Set.add This avoids incompatibilities with the old collections library where Set.add returns whether the element was added. The Java collections do the same.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align Shrinkable with Growable: subtract becomes subtractOne,
the multi-element overload of subtract is removed in favor of -=
Rename Set.insert to Set.add
This avoids incompatibilities with the old collections library where
Set.add returns whether the element was added. The Java collections
do the same.