Fix exit code policy #3377
Merged
Fix exit code policy #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligning expectation that "all repos succeed" means there are no repos with failures.
This brings back the old behavior from RunResults:
if (reposWithFailures.isEmpty) ExitCode.Success else ExitCode.Error
See:
scala-steward-org/scala-steward@6259adb...9d9460a
alejandrohdezma
approved these changes
Jun 25, 2024
|
Good catch @esamson! Thanks! |
rtyley
reviewed
Jul 12, 2024
| val SuccessOnlyIfAllReposSucceed: ExitCodePolicy = successIf(_.reposWithFailures.nonEmpty) | ||
| val SuccessOnlyIfAllReposSucceed: ExitCodePolicy = successIf(_.reposWithFailures.isEmpty) |
There was a problem hiding this comment.
Good catch! Sorry I didn't test that with #3369 - thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning expectation that "all repos succeed" means there are no repos with failures.
This brings back the old behavior from RunResults:
See:
6259adb...9d9460a