Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md to run on ubuntu-latest and install sbt #644

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

yokra9
Copy link
Contributor

@yokra9 yokra9 commented Oct 6, 2024

ubuntu-latest or ubuntu-22.04 runner tags are used on README.md. I think it is better that only ubuntu-latest is documented. But sbt was removed from the ubuntu-latest (equals ubuntu-24.04) runner image. actions/runner-images#10636

This PR makes a README.md fix to run on ubuntu-latest and install sbt. Thanks!

github-actions bot added a commit that referenced this pull request Oct 6, 2024
@mzuehlke
Copy link
Member

mzuehlke commented Oct 6, 2024

Setting up sbt can be much simpler done with the "setup-sbt" action: https://github.com/sbt/setup-sbt

Copy link
Contributor

github-actions bot commented Oct 6, 2024

A snapshot release has been created as snapshots/644.

You can test it out with:

uses: scala-steward-org/scala-steward-action@snapshots/644

It will be automatically recreated on any change to this PR.

github-actions bot added a commit that referenced this pull request Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
core 100% 100% 0
modules 69% 88% 0
Summary 70% (495 / 703) 89% (74 / 83) 0

@yokra9
Copy link
Contributor Author

yokra9 commented Oct 6, 2024

Setting up sbt can be much simpler done with the "setup-sbt" action: https://github.com/sbt/setup-sbt

Thank you for sharing that action! I have modified it to use that.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Makes sense

@exoego exoego merged commit 147c4b1 into scala-steward-org:master Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants