Refresh token every 50 minutes #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnviousSwan
force-pushed
the
use-installation-octokit
branch
from
8b51fac
to
02ce11a
Compare
EnviousSwan
commented
Sep 7, 2024
| @@ -112,7 +112,7 @@ async function gitHubAppToken(app: GitHubAppInfo | undefined, gitHubApiUrl: stri | |||
|
|
|||
| const response = type === 'app' | |||
| ? await auth({type: 'app'}) | |||
| : (app.installation ? await auth({type: 'installation', installationId: app.installation.value}) : undefined) | |||
| : (app.installation ? await auth({type: 'installation', installationId: app.installation.value, refresh: true}) : undefined) | |||
There was a problem hiding this comment.
this is from their docs at https://github.com/octokit/auth-app.js?tab=readme-ov-file#installation-authentication
EnviousSwan
force-pushed
the
use-installation-octokit
branch
from
02ce11a
to
a6093a7
Compare
There was a problem hiding this comment.
Hey @EnviousSwan, thank you so much for taking the time to do this! I'll just left a comment with a minor improvement, overall change looks good and simple 😊
src/modules/workspace.ts
Outdated
Comment on lines
125
to
126
| const newToken = await token() | ||
| this.files.writeFileSync(this.askpass_sh.value, `#!/bin/sh\n\necho '${newToken}'`) |
There was a problem hiding this comment.
nitpick (non-blocking): would you mind extracting this two lines into its own function and just called that function here and inside the setInterval block?
This comment follows the conventionalcomments.org standard
EnviousSwan
force-pushed
the
use-installation-octokit
branch
from
a6093a7
to
e2d6f01
Compare
|
|
A snapshot release has been created as You can test it out with: uses: scala-steward-org/scala-steward-action@snapshots/633It will be automatically recreated on any change to this PR. |
alejandrohdezma
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #625
--git-ask-passfile is now updated every 50 minutes, as the default token expiration is 1 hourAnd workflow can now run longer than one hour with no issues