Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action's revamp 1 of 2 #426

Merged
merged 22 commits into from
Dec 16, 2022
Merged

Action's revamp 1 of 2 #426

merged 22 commits into from
Dec 16, 2022

Conversation

alejandrohdezma
Copy link
Member

💻 How to review this PR?

This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.

I also recommend checking "Hide whitespace" when reviewing this PR!

🚀 What has been done in this PR?

  • Modularize a big part of the action into classes, so they can be easily tested in a subsequent PR.
  • Make the action a little more type-safe.

✅ Already tested

I tested the changes in this PR with the Scala Steward instance I use for my own repos and it works as expected.

@alejandrohdezma alejandrohdezma requested a review from a team December 6, 2022 09:06
@alejandrohdezma alejandrohdezma changed the title Action's revamp Action's revamp 1 of 2 Dec 13, 2022
@alejandrohdezma alejandrohdezma requested review from exoego and removed request for a team December 15, 2022 14:16
@github-actions
Copy link
Contributor

A snapshot release has been created as snapshots/426.

You can test it out with:

uses: scala-steward-org/scala-steward-action@snapshots/426

It will be automatically recreated on any change to this PR.

github-actions bot added a commit that referenced this pull request Dec 16, 2022
@alejandrohdezma alejandrohdezma merged commit 41992bc into master Dec 16, 2022
@alejandrohdezma alejandrohdezma deleted the feature/revamp branch December 16, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants