fix: instead of moving mill cp and then remove #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like there are situations when dealing with mounted drives you get the following error: ``` Error: EXDEV: cross-device link not permitted, rename '/runner/_work/_temp/9b722d14-6935-45f9-ab1a-526911088cbe' -> '/home/runner/bin/mill' ``` From googling around it looks like we can avoid this by instead moving the file first and then removing it. For reference - https://stackoverflow.com/questions/44146393/error-exdev-cross-device-link-not-permitted-rename-nodejs - shelljs/shelljs#191 Fixes: scala-steward-org#421
|
@alejandrohdezma is there a chance we could get this on a branch and then if possible @ybasket would you be able to test it? |
|
@ckipp01 Thank you for looking into this! I'll only be able to test this next week, but do not necessarily need a separate branch as I can pull these changes into my fork and test from there. Will report back. |
alejandrohdezma
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Great catch! Yeah, this should be the way to go, it's the same approach we follow for installing coursier in #30. Sorry I didn't remember when I reviewed the previosu PR 😿
|
This change has been released as version |
|
I can confirm it fixed the issue reported in #421, thank you both for the quick handling of this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there are situations when dealing with mounted drives
you get the following error:
From googling around it looks like we can avoid this by instead
moving the file first and then removing it.
For reference
Fixes: #421